Attention is currently required from: Thomas Heijligen, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58617 )
Change subject: Makefile: unify the look of TARGET_* prints
......................................................................
Patch Set 2: Code-Review+1
(2 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/58617/comment/0d0cba1c_4fa0610b
PS2, Line 7: Makefile: unify the look of TARGET_* prints
Unify with what?
File Makefile:
https://review.coreboot.org/c/flashrom/+/58617/comment/a48ba5bf_68e977fb
PS2, Line 902: @if [ $(TARGET_OS) = libpayload ] && $(CC) --version 2>&1 | grep -q -v coreboot; then \
`grep -v` looks for any non-matching line
--
To view, visit
https://review.coreboot.org/c/flashrom/+/58617
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I69959c20aa2e43ed67b3057c37e964a34cdab136
Gerrit-Change-Number: 58617
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Tue, 26 Oct 2021 12:30:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment