[S] Change in flashrom[master]: meson: revert to meson version 0.53.0 - flashrom-gerrit

2 Mar 2023


      Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73361 )
Change subject: meson: revert to meson version 0.53.0
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/73361/comment/1e9dd381_cca7bd2f 
PS1, Line 10: Pass arguments to `sphinx-doc` via `'-Dkey=value`
...
In `doc/meson.build` where sphinx is called as custom_target. […]
Yes, I understand it better now, thanks for the explanation! I think it would be very good to add the specific info into commit message: instead of saying "key=value" say what option is set and why.
Pass release version into sphinx-doc because it is needed for XYZ reasons
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/73361
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Iff9b8307c741a247a652cf666935c9485fa493fa
Gerrit-Change-Number: 73361
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Alexander Goncharov chat@joursoir.net
Gerrit-Comment-Date: Thu, 02 Mar 2023 11:50:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen src@posteo.de
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Gerrit-MessageType: comment