Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59075 )
Change subject: [RFC] tests: add test of write protection
......................................................................
Patch Set 3:
(3 comments)
Patchset:
PS2:
Just to double-check, is this chain going to be on the top of https://review.coreboot. […]
Correct, I exclude those commits before pushing because last time I didn't gerrit updated patchsets for changes that I didn't mean to update.
File tests/write_protection.c:
https://review.coreboot.org/c/flashrom/+/59075/comment/df5d3c0c_7c6c5ed5
PS2, Line 2: This file
How about a bit shorter name: write_protect.c? Same meaning, less chars. […]
Done
https://review.coreboot.org/c/flashrom/+/59075/comment/f16e1293_b1977d2d
PS2, Line 101: test_failure
Is this […]
Done
--
To view, visit
https://review.coreboot.org/c/flashrom/+/59075
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I49af7f6d173eb4c56c22d80b01a473b8c499c0f8
Gerrit-Change-Number: 59075
Gerrit-PatchSet: 3
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-CC: Nikolai Artemiev
nartemiev@google.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Thu, 11 Nov 2021 23:45:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment