[M] Change in flashrom[master]: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME

[Anastasia Klimchuk (Code Review)]

Attention is currently required from: Angel Pons, Martin L Roth, Martin Roth, Raj Astekar, Ravishankar Sarawadi, Wonkyu Kim.

Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58025?usp=email )

Change subject: flashchips: Add support for GigaDevice GD25LR256E, GD251R512ME
......................................................................

Patch Set 8: Code-Review+1

(3 comments)

Commit Message:

https://review.coreboot.org/c/flashrom/+/58025/comment/f15c2923_db833be5 :
PS6, Line 11:   https://www.gigadevice.com/datasheet/gd25lr512me/
> Updated to archive. […]

Thanks! I don't know whether it's my local issue, but I downloaded both pdf documents, and none of them can be opened :\ Do the docs open for you? (after downloading?)

https://review.coreboot.org/c/flashrom/+/58025/comment/10f88931_5226397d :
PS6, Line 17: sudo dut-control cold_reset:on fw_wp_en:off spi2_buf_en:on spi2_buf_on_flex_en:on spi2_vref:pp1800 spi_hold:off
            : sudo flashrom -V -p raiden_debug_spi -w <test_binary>
            : sudo dut-control spi2_buf_en:off spi2_buf_on_flex_en:off spi2_vref:off spi_hold:off cold_reset:off
> I only have access to the gd25lr512me chip and flashed with a dediprog. […]

Yes, maybe it's not that critical to see the exact command, but I am for example interested which programmers are used (and tested, as a side-effect).

We do have PREWB to indicate that write-protect is tested for the chip (I assume this is the locking functionality you mentioned, which we usually call write-protect).
Because both letters W and P were taken already, it got letter B for block-protect.

I can mark this as resolved it seems. Thank you!

Patchset:

PS8: 
just one thing I wanted to double-check about the datasheets