Attention is currently required from: Subrata Banik, Nico Huber, Angel Pons, Anastasia Klimchuk. Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62891 )
Change subject: ichspi: Introduce FCYCLE_MASK(n) macro ......................................................................
Patch Set 7:
(2 comments)
Patchset:
PS6:
What's the benefit of these changes? To me, the `FCYCLE_MASK` macro makes things more noisy. Also, note that the definitions are organized so that PCH100 differences appear first.
I have added the motivation here: This patch introduces HSFC_FCYCLE_MASK(n) macro to cover both ICH and PCH hardware sequencing FCYCLE Bit width.
Also without this CL, the Flash Cycle bit field width is wrong for latest chipset. It's 4 bit width on PCH as per EDS but without this CL, we are still considering it 2 bit.
Having a macro that unifies the FYCLE mask is the intention and once we rectified the same, we need to add the corresponding changes. May be that is what you call as *noisy*.
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/62891/comment/69633dc7_b4b7564c PS6, Line 162: n
Please add parentheses around macro parameters
Ack
-
Subrata Banik (Code Review)