Attention is currently required from: Nico Huber, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/54714 )
Change subject: sb600spi.c: Drop sb600_ prefix for spi data struct member
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/54714/comment/52d8adfb_2b016f6e
PS1, Line 9: sb600spi_
nit, pedantic: Strictly speaking, this prefix is only used in the name of the struct *type*. […]
If I understand you correctly, this is about commit message - so I changed it a little bit to mention struct type.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/54714
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I001ae2044453d1bc205fa253ffb773ed993f57f8
Gerrit-Change-Number: 54714
Gerrit-PatchSet: 2
Gerrit-Owner: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 21 May 2021 00:24:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment