Attention is currently required from: Thomas Heijligen, Jean THOMAS.
Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67878 )
Change subject: dirtyjtag: Add DirtyJTAG programmer ......................................................................
Patch Set 4:
(3 comments)
File dirtyjtag_spi.c:
https://review.coreboot.org/c/flashrom/+/67878/comment/a253dc55_4cbe494d PS4, Line 120: static inline unsigned int _min(unsigned int a, unsigned int b) : { : return (a < b) ? a : b; : } Seems to be unused?
https://review.coreboot.org/c/flashrom/+/67878/comment/551fc13b_0b284884 PS4, Line 133: msg_perr("%s: Failed tx_buf allocation", __func__); Missing \n
https://review.coreboot.org/c/flashrom/+/67878/comment/ffc9b933_c42fb4b0 PS4, Line 138: msg_perr("%s: Failed rx_buf allocation", __func__); Missing \n