Attention is currently required from: Xiang W, Stefan Reinauer, Angel Pons.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49264 )
Change subject: bitbang_spi.c: fix spi sequence in time and rename
......................................................................
Patch Set 16: Code-Review-1
(1 comment)
Patchset:
PS16:
SCK and MOSI should be changed at once and some bitbang programmers
do so. We must not rely on the order. This change is only necessary
to cover up the bugs introduced in the previous commit.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49264
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I107803afef044996c94ebfaf0b0e0040cea9f8c1
Gerrit-Change-Number: 49264
Gerrit-PatchSet: 16
Gerrit-Owner: Xiang W
wxjstz@126.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Shawn C
citypw@hardenedlinux.org
Gerrit-Attention: Xiang W
wxjstz@126.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 11 Jun 2021 14:31:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment