Attention is currently required from: Nico Huber, Martin L Roth.
Hello build bot (Jenkins), Nico Huber, Martin L Roth,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/flashrom/+/67999
to review the following change.
Change subject: test_build.sh: Allow WARNERROR to be overridden ......................................................................
test_build.sh: Allow WARNERROR to be overridden
Currently, WARNERROR is hardcoded to 'yes' which is what we want most of the time, but there are cases (such as when building with -fanalyzer) that we don't want it enabled, so we see the entire output of the build, and it doesn't halt at the first error. Removing the WARNERROR line from the script allows the variable to be overridden from an environment variable.
Signed-off-by: Martin Roth gaumless@gmail.com Change-Id: Iea931e57f2a6992762566dc3dbaae8bb8df5b226 Reviewed-on: https://review.coreboot.org/c/flashrom/+/62745 Reviewed-by: Felix Singer felixsinger@posteo.net Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M test_build.sh 1 file changed, 22 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/99/67999/1
diff --git a/test_build.sh b/test_build.sh index 0064c8f..6cb902c 100755 --- a/test_build.sh +++ b/test_build.sh @@ -2,4 +2,4 @@ set -e
make clean -make CONFIG_EVERYTHING=yes WARNERROR=yes +make CONFIG_EVERYTHING=yes