Nico Huber has posted comments on this change. ( https://review.coreboot.org/19420 )
Change subject: spi25: Fix layering violation in probe_spi_rdid4() ......................................................................
Patch Set 2: Code-Review-2
(1 comment)
Will update this (sometime).
https://review.coreboot.org/#/c/19420/2/wbsio_spi.c File wbsio_spi.c:
https://review.coreboot.org/#/c/19420/2/wbsio_spi.c@73 PS2, Line 73: .max_data_read = 3,
The table above wbsio_spi_send_command() implies that this is 4. It seems y
Letting wbsio_spi_send_command() handle it sounds way better than what I did, thanks!
I first thought the code in spi25.c was there to make sure we return 0 on this error, but that seems to be handled deeper down already.