[M] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par_master
Attention is currently required from: Thomas Heijligen, Edward O'Callaghan, Nikolai Artemiev, Peter Marheine.
Jonathon Hall has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 )
Change subject: drivers: Move (un)map_flash_region from programmer to par_master ......................................................................
Patch Set 3:
(4 comments)
Patchset:
PS2:
Yeah I think that would also work. […]
Got this reworked, I agree that it's a lot cleaner. Only par_master provides mapping functions now, so this supersedes the specific change to ICH SPI hwseq, and the other SPI masters no longer use specialized mappers.
File atapromise.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/3d7c69d8_2fbbd3dd PS2, Line 133: atapromise_map
Agree, will tweak this when I'm back Tuesday.
Removed this, also updated the comment in fallback_map() since returning NULL is the desired behavior.
File atavia.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/51d68ad5_45734160 PS2, Line 147: atavia_map
If you can test that would be awesome, FWIW I could keep this around even if we move the mapper into […]
I kept this around for now since I can't test it and it doesn't hurt the overall structure. We could always remove it later, or if anybody tests it let me know and I can take it out.
File serprog.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/6251a499_1080b494 PS2, Line 582: .map_flash_region = serprog_map,
Does anyone know if this is needed? […]
I had to take this out to rework the mapper into par_master - I'm pretty sure it's not needed, but I don't have any hardware to test on.
-
Jonathon Hall (Code Review)