Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58474 )
Change subject: writeprotect, cli_classic: delete old writeprotect code ......................................................................
Patch Set 10:
(3 comments)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/58474/comment/046e4e5c_b58abb01 PS9, Line 159: int set_wp_enable, : int set_wp_disable, : int wp_status, : int set_wp_range, : int wp_list,
These all are commands/actions? I noticed some of them start with verb "set" and others start with a […]
Done - I've renamed them and moved all the WP CLI code to the final CL.
https://review.coreboot.org/c/flashrom/+/58474/comment/e6bf2d26_de3ebe41 PS9, Line 786: set_wp_range || (set_wp_region && wp_region)
A tiny bit confusing, because function param is named simply `set_wp_range` however actual argument […]
I've refactored it a bit in the WP CLI patch.
--wp-region is just a different way of specifying a protection region using a fmap file. It should mostly do the same thing as --wp-range.
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/58474/comment/b61ed326_9fd45cb7 PS9, Line 4: 2010
I don't see why a commit that says `delete` in its summary should be adding anything.
Done - I've now completely removed WP CLI code so we don't need to add the flashrom_wp_mode enum in this CL.
As for the copyright line, I just copied it from the writeprotect.h file along with the wp mode enum.
-
Nikolai Artemiev (Code Review)