Miriam Polzer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48880 )
Change subject: Add missing platform.h includes ......................................................................
Add missing platform.h includes
Include platform.h in all files using its macros.
BUG=none TEST=builds
Signed-off-by: Miriam Polzer mpolzer@google.com Change-Id: If17a3d58c02222f61b4e0335879eeed1638b583c --- M ch341a_spi.c M internal.c 2 files changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/80/48880/1
diff --git a/ch341a_spi.c b/ch341a_spi.c index 17c37eb..84cc3fe 100644 --- a/ch341a_spi.c +++ b/ch341a_spi.c @@ -20,6 +20,7 @@ #include <string.h> #include <libusb.h> #include "flash.h" +#include "platform.h" #include "programmer.h"
/* LIBUSB_CALL ensures the right calling conventions on libusb callbacks. diff --git a/internal.c b/internal.c index 4390b45..bdbe32d 100644 --- a/internal.c +++ b/internal.c @@ -18,6 +18,7 @@ #include <string.h> #include <stdlib.h> #include "flash.h" +#include "platform.h" #include "programmer.h" #include "hwaccess.h"
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48880 )
Change subject: Add missing platform.h includes ......................................................................
Patch Set 1: Code-Review+1
Missing headers? Was something broken?
Idwer Vollering has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48880 )
Change subject: Add missing platform.h includes ......................................................................
Patch Set 1:
Also, platform.h is already included through os.h
David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48880 )
Change subject: Add missing platform.h includes ......................................................................
Patch Set 1: Code-Review+2
Miriam Polzer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48880 )
Change subject: Add missing platform.h includes ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+1
Missing headers? Was something broken?
It was broken until platform.h was added to flash.h, yes. I'd like to avoid transitive includes that's why I'm adding the inlcude everwhere now. Otherwise somebody might break this unknowingly again by removing the include in flash.h or somewhere else.
Miriam Polzer has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48880 )
Change subject: Add missing platform.h includes ......................................................................
Patch Set 1:
Thanks for the review! I've never submitted code here and it tells me I don't have permission, what am I missing? 😄
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48880 )
Change subject: Add missing platform.h includes ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48880 )
Change subject: Add missing platform.h includes ......................................................................
Patch Set 1:
Patch Set 1:
Thanks for the review! I've never submitted code here and it tells me I don't have permission, what am I missing? 😄
Only developers can submit patches, even after they've been approved. It's too easy to submit a patch train out-of-order by accident and break building the master branch until someone issues a fix. With great power comes great responsibility :D
Angel Pons has submitted this change. ( https://review.coreboot.org/c/flashrom/+/48880 )
Change subject: Add missing platform.h includes ......................................................................
Add missing platform.h includes
Include platform.h in all files using its macros.
BUG=none TEST=builds
Signed-off-by: Miriam Polzer mpolzer@google.com Change-Id: If17a3d58c02222f61b4e0335879eeed1638b583c Reviewed-on: https://review.coreboot.org/c/flashrom/+/48880 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Idwer Vollering vidwer@gmail.com Reviewed-by: David Hendricks david.hendricks@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com --- M ch341a_spi.c M internal.c 2 files changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified David Hendricks: Looks good to me, approved Idwer Vollering: Looks good to me, but someone else must approve Angel Pons: Looks good to me, approved
diff --git a/ch341a_spi.c b/ch341a_spi.c index 17c37eb..84cc3fe 100644 --- a/ch341a_spi.c +++ b/ch341a_spi.c @@ -20,6 +20,7 @@ #include <string.h> #include <libusb.h> #include "flash.h" +#include "platform.h" #include "programmer.h"
/* LIBUSB_CALL ensures the right calling conventions on libusb callbacks. diff --git a/internal.c b/internal.c index 4390b45..bdbe32d 100644 --- a/internal.c +++ b/internal.c @@ -18,6 +18,7 @@ #include <string.h> #include <stdlib.h> #include "flash.h" +#include "platform.h" #include "programmer.h" #include "hwaccess.h"
-
Angel Pons (Code Review) -
David Hendricks (Code Review)
-
Idwer Vollering (Code Review)
-
Miriam Polzer (Code Review)