Attention is currently required from: Angel Pons.
Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49268 )
Change subject: bitbang_spi: Drop `set_mosi` and `get_miso` operations
......................................................................
Patch Set 1: Code-Review-1
(1 comment)
Patchset:
PS1:
Not every platform can use this method to speed up, and the deleted interface helps portability. The set_sck_set_mosi in bitbang_spi.c can all go wrong, why do you think those who adapt better understand the working principle of spi?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/49268
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id6b1edb1e01330feffc5f1ed2ca2c2ebc4fb3b66
Gerrit-Change-Number: 49268
Gerrit-PatchSet: 1
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Xiang Wang
merle@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 10 Jan 2021 15:23:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment