Change in flashrom[master]: tests: Add unit test to run init/shutdown for mec1308.c, ene_lpc.c
Attention is currently required from: Nico Huber, Edward O'Callaghan, Angel Pons, Simon Glass. Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/51487 )
Change subject: tests: Add unit test to run init/shutdown for mec1308.c, ene_lpc.c ......................................................................
Patch Set 13:
(2 comments)
Patchset:
PS13: I rebased this on the top of io_mock.h. Also I went through all the comments to summarize what's left to do / to decide on:
1) Moving hwaccess_io_unittest.h into tests/ directory? a) there is a unittest_env.h in the same situation, these two files should be moved (or not moved) together, and probably in a separate patch? b) I don't know whether I can move flashrom_test_dep into tests/meson.build because it is using srcs and deps from root meson.build.
2) Configure verbosity level for LOG_ME messages a) agree it would be cool, don't know how to do this yet
3) Need to fix compiler warning ../tests/tests.c:30:13: warning: assignment discards ‘const’ qualifier from pointer target type But the question in general is whether I am using `io_mock_register` in a right way?
File tests/init_shutdown.c:
https://review.coreboot.org/c/flashrom/+/51487/comment/bbe3c91f_4c759b19 PS10, Line 46: struct mec1308_test_data *test_data = current_io->test_data;
I think you should add a blank line between decls and code
Done
-
Anastasia Klimchuk (Code Review)