Attention is currently required from: Aarya.
Hello Aarya,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/81385?usp=email
to look at the new patch set (#2).
Change subject: WIP: erasure_layout: Fix get_flash_region bug ......................................................................
WIP: erasure_layout: Fix get_flash_region bug
This effectively exchanges the nesting of the loops over erase blocks and flash regions.
Old: - Select erasefns - Loop over blocks to erase for each selected erasefn - Loop over programmer flash regions within erase block - Erase regions (may fail since selected erasefn will be too big if flash region is smaller than erase block)
New: - Loop over programmer flash regions within erase block - Select erasefns within programer flash region - Loop over blocks to erase for each selected erasefn - Erase regions
Eraser selection and erasing has also been factored out into a helper function to manage nesting depth.
TEST=builds BUG=none BRANCH=none
Change-Id: I5d8492351a1ac5832227cbdbe40dea7b9ac3abd1 Signed-off-by: Nikolai Artemiev nartemiev@google.com --- M erasure_layout.c 1 file changed, 102 insertions(+), 92 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/85/81385/2