David Hendricks has posted comments on this change. ( https://review.coreboot.org/19420 )
Change subject: spi25: Fix layering violation in probe_spi_rdid4() ......................................................................
Patch Set 2: Code-Review-1
(1 comment)
I'm not sure how this will affect wbsio_spi.c. Can you please explain the impact of setting max_data_read to 3 a bit more? I have no experience with that hardware, so there might be something you know that I don't.
https://review.coreboot.org/#/c/19420/2/wbsio_spi.c File wbsio_spi.c:
https://review.coreboot.org/#/c/19420/2/wbsio_spi.c@73 PS2, Line 73: .max_data_read = 3, The table above wbsio_spi_send_command() implies that this is 4. It seems you set it to 3 here since there isn't a mode that supports 4-byte RDID (1 command byte + 4 data read). I'm wondering if it's cleaner to leave this as MAX_DATA_UNSPECIFIED and let it fail in wbsio_spi_send_command().
-
David Hendricks (Code Review)