Change in flashrom[master]: [RFC] writeprotect: implement wp_get_ranges() - flashrom-gerrit

30 Oct 2021


      Attention is currently required from: Nikolai Artemiev.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58481 )
Change subject: [RFC] writeprotect: implement wp_get_ranges()
......................................................................
Patch Set 6:
(1 comment)
File writeprotect.h:
https://review.coreboot.org/c/flashrom/+/58481/comment/fcf1027d_e315eaa2 
PS6, Line 57: wp_get_ranges
How about renaming it to, say, `wp_list_ranges` to make it less confusing? This will separate it from `wp_get_range` and be less suggestive of getting ranges from somewhere as they are actually generated by this function.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/58481
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Id51f038f03305c8536d80313e52f77d27835f34d
Gerrit-Change-Number: 58481
Gerrit-PatchSet: 6
Gerrit-Owner: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Sat, 30 Oct 2021 16:30:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment