Change in flashrom[master]: ite_ecfw: Implement support for flashing ITE ECs found on TUXEDO laptops - flashrom-gerrit

26 Feb 2022


      Attention is currently required from: Felix Singer, Michał Żygowski, Paul Menzel, Sergii Dmytruk.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55715 )
Change subject: ite_ecfw: Implement support for flashing ITE ECs found on TUXEDO laptops
......................................................................
Patch Set 29:
(1 comment)
File ite_ecfw.c:
https://review.coreboot.org/c/flashrom/+/55715/comment/ea655b2d_8a0c9373 
PS29, Line 495: (uint8_t *)
Ah, I was too tired yesterday when I read this and didn't
see the cast. I guess this is what makes the verification
work by chance?
Such a cast is a no-go.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/55715
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I0e42260155ffea38a6f60790871cd8da7b657031
Gerrit-Change-Number: 55715
Gerrit-PatchSet: 29
Gerrit-Owner: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Michał Żygowski michal.zygowski@3mdeb.com
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Sergii Dmytruk sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Sat, 26 Feb 2022 16:57:46 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment