[M] Change in flashrom[master]: sb600spi.c: Move promontory code into a mmap_read=yes mode - flashrom-gerrit

11 Jan 2023


      Attention is currently required from: Thomas Heijligen, Edward O'Callaghan.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/71565 )
Change subject: sb600spi.c: Move promontory code into a mmap_read=yes mode
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/71565/comment/56fb5635_e0a7e86f 
PS2, Line 10: This is not
            : hardware specific
...
I believe it is hardware specific to controllers after a certain generation. i.e., supported on SPI100 controllers (Zen etc) however not supported on pre-SPI100 controllers was my understanding.
I think the parts controlling the speed and mode might not apply, but it is memory mapped for sure.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/71565
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I13eb5a646d3569170b3911ae7b3127cd3e6022aa
Gerrit-Change-Number: 71565
Gerrit-PatchSet: 2
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Thomas Heijligen src@posteo.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Wed, 11 Jan 2023 14:58:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment