Nico Huber has posted comments on this change. ( https://review.coreboot.org/19206 )
Change subject: Convert flashrom to git ......................................................................
Patch Set 1:
(7 comments)
Not quite through...
https://review.coreboot.org/#/c/19206/1//COMMIT_MSG Commit Message:
PS1, Line 84: Acked-by: Stefan Tauner stefan.tauner@alumni.tuwien.ac.at I'd drop this since it's not this revision he acked.
https://review.coreboot.org/#/c/19206/1/Makefile File Makefile:
PS1, Line 1357: "$(MAN_DATE)" This overwrites the default system-management heading (center of first line). Why? it's also not mentioned in the commit message.
https://review.coreboot.org/#/c/19206/1/util/getrevision.sh File util/getrevision.sh:
PS1, Line 41: upcache_refs uninitialized
PS1, Line 44: # We need to update our upstream information sometimes so that we can create detailed version information. : # To that end the code below fetches parts of the upstream repository via https. : # This takes about one second or less under normal circumstances. Do we break lines only at full stops now? This looks like a single paragraph to me. Everything wider than about 70 chars limits reada- bility.
Applies to many comments in this file.
Line 66: upstream repositories as git remote to rely on that information. Is here supposed to start a new paragraph? Please separate them with an empty line.
Also, please break the whole text somewhere between 60~70 chars. We want people to read it, don't we?
PS1, Line 86: "$1" This is an empty string if $1 is not set. It still works, but git already complains that it won't much longer.
PS1, Line 218: previse precise?