Attention is currently required from: Nico Huber, Angel Pons, Anastasia Klimchuk. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/55741 )
Change subject: tests: Guard sys/io.h the same as in hwaccess_x86_io.h ......................................................................
Patch Set 2:
(3 comments)
File hwaccess_x86_io_unittest.h:
https://review.coreboot.org/c/flashrom/+/55741/comment/e0186702_8b9aac89 PS2, Line 32: `#if defined(__i386__) || defined(__x86_64__)`
https://review.coreboot.org/c/flashrom/+/55741/comment/b7c2e725_667515f4 PS2, Line 41: #if IS_X86 && defined(__linux__) || defined(__GLIBC__) For the `IS_x86`, don't guard #include stmt's as it adds a lot of cyclomatic complexity to the preprocessor pass. Guarding #include's for multi-platform reasons maybe unavoidable.
Simply guard the whole file as this only applies on platforms with ported io (i.e., x86). It will then evaluate as a empty include file, this lets the toolchain do its job.
https://review.coreboot.org/c/flashrom/+/55741/comment/5b651461_2b77d16f PS2, Line 53: `#endif /* __i386__ || __x86_64__ */`
-
Edward O'Callaghan (Code Review)