Attention is currently required from: Stefan Reinauer, Edward O'Callaghan, Angel Pons. Xiang Wang has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49254 )
Change subject: sysfsgpio.c implement spi interface via linux sysfs ......................................................................
Patch Set 4:
(7 comments)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49254/comment/3ac20de4_10e217b2 PS1, Line 10: some SBC
Include this information in your commit message on a `TEST=` line perhaps?
Done
File sysfsgpio.c:
https://review.coreboot.org/c/flashrom/+/49254/comment/d722c5d8_51c4baf8 PS3, Line 46: pins
`g_pins`
Done
https://review.coreboot.org/c/flashrom/+/49254/comment/41f89a75_323857ba PS3, Line 157: p
g_
Done
https://review.coreboot.org/c/flashrom/+/49254/comment/cd245d89_dee19e01 PS3, Line 184: p
g_
Done
https://review.coreboot.org/c/flashrom/+/49254/comment/6cad12d2_16933f0d PS3, Line 204: static int parse_pins(void)
`static int parse_pins(struct sysfsgpio_pins *pins)`
Done
https://review.coreboot.org/c/flashrom/+/49254/comment/178ab6d8_8357ae91 PS3, Line 241: )
`parse_pins(&g_pins)`
Done
https://review.coreboot.org/c/flashrom/+/49254/comment/bddb9980_6654f0fc PS3, Line 244: p
g_
Done
-
Xiang Wang (Code Review)