Attention is currently required from: Nikolai Artemiev, Stefan Reinauer, Victor Lim.
Anastasia Klimchuk has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/84083?usp=email )
Change subject: flashchips: add GD25B512MF and GD25R512MF
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
Patchset:
PS1:
All good in the code, but you will need to rebase this patch on the top of main branch.
It says "merge conflict", but I think there is no actual conflict. It's just that the adjacent lines, just before in the same file, were submitted in the other patch earlier.
Tell me if rebasing won't work, I will have a look.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/84083?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I9821efb34fb4abb806ad52acec46aad186888c07
Gerrit-Change-Number: 84083
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Lim
vlim@gigadevice.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Victor Lim
vlim@gigadevice.com
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Thu, 29 Aug 2024 02:44:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes