Attention is currently required from: Anastasia Klimchuk, Alexander Goncharov.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67700 )
Change subject: stlinkv3_spi: fix uninitialized pointer
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Thomas what do you think is the state of CB:66225 ? It does seem to cover a bit more (3 lines vs 1 l […]
As I mention in CB:66225 the `maybe-uninitialized` or scan-builds `core.uninitialized.Branch` are false positives in this case.
My suggestion would be to add a comment `libusb_device_handle *stlinkv3_handle = NULL; /* NULL for suppressing scan-build false positive core.uninitialized.Branch */`
The other lines of CB:66225 are not needed any longer. The underlaying is solved
I don't care which patch will make it.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/67700
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ibaf25f67186724d9045ade849026782c3eac4952
Gerrit-Change-Number: 67700
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Felix Singer
felixsinger@posteo.net
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Alexander Goncharov
chat@joursoir.net
Gerrit-Comment-Date: Tue, 20 Sep 2022 10:02:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Thomas Heijligen
src@posteo.de
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment