Attention is currently required from: Hsuan Ting Chen, Hsuan-ting Chen, Kane Chen, Peter Marheine.
Kane Chen has posted comments on this change by Kane Chen. ( https://review.coreboot.org/c/flashrom/+/83896?usp=email )
Change subject: Provide an option to use PCI_ACCESS_ECAM to access pci register
......................................................................
Patch Set 3:
(1 comment)
File meson_options.txt:
https://review.coreboot.org/c/flashrom/+/83896/comment/d341e2b2_0241c83c?usp... :
PS3, Line 9: option('use_libpci_ecam', type : 'boolean', value : false)
It looks like this is only used for 100-series PCHs which presumably always support ECAM, so is this […]
My original thought is to avoid any potential impact since i only have chromebooks to verify.
if it's ok to use ECAM directly, i can remove this option.
thank you
--
To view, visit
https://review.coreboot.org/c/flashrom/+/83896?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I4549f87c8b01da0a1d3d8ce0b3b75c1f5fa2cbab
Gerrit-Change-Number: 83896
Gerrit-PatchSet: 3
Gerrit-Owner: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Reviewer: Hsuan-ting Chen
roccochen@google.com
Gerrit-Reviewer: Peter Marheine
pmarheine@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-CC: Kane Chen
kane.chen@intel.corp-partner.google.com
Gerrit-Attention: Hsuan Ting Chen
roccochen@chromium.org
Gerrit-Attention: Hsuan-ting Chen
roccochen@google.com
Gerrit-Attention: Kane Chen
kane.chen@intel.com
Gerrit-Attention: Peter Marheine
pmarheine@chromium.org
Gerrit-Comment-Date: Fri, 16 Aug 2024 05:12:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Peter Marheine
pmarheine@chromium.org