Attention is currently required from: Stefan Reinauer, Anastasia Klimchuk, Peter Marheine.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73359 )
Change subject: doc: Add build instructions ......................................................................
Patch Set 3:
(5 comments)
File doc/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/73359/comment/b676da32_df7cbd47 PS1, Line 206: To get a code coverage report
Maybe it's just me, but original instructions feel easier to understand and follow. […]
I've updated to be close to the old one. I thought llvm would be better integrated with the standard tools of meson.
File doc/developers_doc/building_from_source.rst:
https://review.coreboot.org/c/flashrom/+/73359/comment/34561272_93faec67 PS3, Line 105: py-
This is py39-sphinx
Done
https://review.coreboot.org/c/flashrom/+/73359/comment/de86d810_fea2669e PS3, Line 113: install
just `pkg_add`, no `install` needed
Done
https://review.coreboot.org/c/flashrom/+/73359/comment/77c675a3_0d346ee6 PS3, Line 114: py-sphinx
py3-sphinx
Done
https://review.coreboot.org/c/flashrom/+/73359/comment/23ee2cec_7cccfcd4 PS3, Line 175: .. todo:: Write a sphinx extension to render ``meson_options.txt`` here
IIRC `meson configure` will only work when you already have a builddir configured. […]
ok, `meson configure` has different behavior with and without a build directory.
I've now put the `meson configure` variant here. But still behind the idea to render an updated `meson_options.txt` here
-
Thomas Heijligen (Code Review)