Attention is currently required from: Felix Singer, Nico Huber, Michael Niewöhner. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57810 )
Change subject: ft2232_spi: reintroduce generic GPIOL control ......................................................................
Patch Set 17: Code-Review+1
(4 comments)
File ft2232_spi.c:
https://review.coreboot.org/c/flashrom/+/57810/comment/60592f80_b44e96a2 PS17, Line 493: unsigned int pin = temp + 4; Is this change intentional?
https://review.coreboot.org/c/flashrom/+/57810/comment/c1e9b64b_19f9a517 PS17, Line 503: pindir |= 1 << pin; Is this change intentional?
https://review.coreboot.org/c/flashrom/+/57810/comment/57ff1b54_1647e1b5 PS17, Line 524: int Why not `uint8_t`?
https://review.coreboot.org/c/flashrom/+/57810/comment/5a9c7db5_f8ea4dda PS17, Line 526: %i Out of curiosity, why use `%i` here and `%d` in `snprintf()`?
-
Angel Pons (Code Review)