Change in flashrom[master]: tests: Remove mock struct pci_dev, use real pci symbols in tests - flashrom-gerrit

21 Mar 2022


      Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62948 )
Change subject: tests: Remove mock struct pci_dev, use real pci symbols in tests
......................................................................
Patch Set 1: Code-Review+1
(1 comment)
Patchset:
PS1: 
Nit: For the future: can we have standalone mock headers for usb, pci, hwaccess, ...? That we could build and test a not CONFIG_EVERYTHING version of flashrom? (Just an idea, I'm not familiar with cmocka)
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62948
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I1206fbdca392f190066a364376ce0db28071e53c
Gerrit-Change-Number: 62948
Gerrit-PatchSet: 1
Gerrit-Owner: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Comment-Date: Mon, 21 Mar 2022 08:25:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment