Change in flashrom[master]: ichspi: Add Jasper Lake support - flashrom-gerrit

24 Feb 2022


      Attention is currently required from: Edward O'Callaghan.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62282 )
Change subject: ichspi: Add Jasper Lake support
......................................................................
Patch Set 4:
(2 comments)
Patchset:
PS4:
...
As far as I know, no, it's small core. […]
Sorry, I'm a little confused now. Did you actually read the code and the Jasper
Lake documentation or did you just assume it's the same as for other small cores?
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/62282/comment/fa783c49_b95b4c46 
PS4, Line 1064: 	case CHIPSET_JASPER_LAKE:
...
I wasn't sure so I cased it to match with Elkhart not to be odd.
It's a switch/case on `guess`. The guessing code wasn't updated AFAICS.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/62282
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ib942d0b8942fe0a991b2af0b187414818485153d
Gerrit-Change-Number: 62282
Gerrit-PatchSet: 4
Gerrit-Owner: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Subrata Banik subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Angel Pons th3fanbus@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Sam McNally sammc@google.com
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Comment-Date: Thu, 24 Feb 2022 12:37:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Edward O'Callaghan quasisec@chromium.org
Gerrit-MessageType: comment