Nikolai Artemiev has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/48443 )
Change subject: flashchips.c: Add Sanyo LF25FW203A entry ......................................................................
flashchips.c: Add Sanyo LF25FW203A entry
Chip imported from cros flashrom at `commit e50562c68fc4901acb6243b4f4d2c182a162ad41`
Change-Id: I530e123e49d50b032496f18efce438e9ad7e7552 Signed-off-by: Nikolai Artemiev nartemiev@google.com --- M flashchips.c 1 file changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/48443/1
diff --git a/flashchips.c b/flashchips.c index bc5de4a..76b530a 100644 --- a/flashchips.c +++ b/flashchips.c @@ -15659,6 +15659,32 @@ },
{ + .vendor = "Sanyo", + .name = "LF25FW203A", + .bustype = BUS_SPI, + .manufacture_id = SANYO_ID, + .model_id = SANYO_LE25FW203A, + .total_size = 2048, + .page_size = 256, + .tested = TEST_UNTESTED, + .probe = probe_spi_rdid, + .probe_timing = TIMING_ZERO, + .block_erasers = + { + { + .eraseblocks = { {64 * 1024, 32} }, + .block_erase = spi_block_erase_d8, + }, { + .eraseblocks = { {2 * 1024 * 1024, 1} }, + .block_erase = spi_block_erase_c7, + } + }, + .unlock = spi_disable_blockprotect, + .write = spi_chip_write_256, + .read = spi_chip_read, + }, + + { .vendor = "Sharp", .name = "LH28F008BJT-BTLZ1", .bustype = BUS_PARALLEL,
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/flashrom/+/48443
to look at the new patch set (#2).
Change subject: flashchips.c: Add Sanyo LF25FW203A entry ......................................................................
flashchips.c: Add Sanyo LF25FW203A entry
Chip imported from cros flashrom at `commit e50562c68fc4901acb6243b4f4d2c182a162ad41`
BUG=b:174432081 TEST=builds
Change-Id: I530e123e49d50b032496f18efce438e9ad7e7552 Signed-off-by: Nikolai Artemiev nartemiev@google.com --- M flashchips.c 1 file changed, 26 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/43/48443/2
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/48443 )
Change subject: flashchips.c: Add Sanyo LF25FW203A entry ......................................................................
Patch Set 2: Code-Review-2
This looks like it came from commit,
``` commit 4d31f0d41f6c7df7f46814c4f5e5ef9d182c0f40 Author: snelson snelson@2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 Date: Tue Jan 19 03:23:07 2010 +0000
Convert chips to block_erasers: ST_M25PE10 ST_M25PE20 ST_M25PE40 ST_M25PE80 ST_M25PE16 PMC_25LV010 PMC_25LV016B PMC_25LV020 PMC_25LV040 PMC_25LV080B PMC_25LV512 PMC_39F010 PMC_49FL002 PMC_49FL004 SANYO_LE25FW203A SPANSION_S25FL016A
Added spi_block_erase_d7 for PMC chips.
Signed-off-by: Sean Nelson audiohacked@gmail.com Acked-by: Carl-Daniel Hailfinger c-d.hailfinger.devel.2006@gmx.net
git-svn-id: svn://coreboot.org/flashrom/trunk@867 2b7e53f0-3cfb-0310-b3e9-8179ed1497e1 ```
and already exists in upstream, https://github.com/flashrom/flashrom/blob/master/flashchips.c#L15473
Therefore this is a duplicate chip in the ChromiumOS fork of Flashrom and should be removed.
Nikolai Artemiev has abandoned this change. ( https://review.coreboot.org/c/flashrom/+/48443 )
Change subject: flashchips.c: Add Sanyo LF25FW203A entry ......................................................................
Abandoned
duplicate