Attention is currently required from: Dmitry Zhadinets.
Peter Marheine has posted comments on this change by Dmitry Zhadinets. ( https://review.coreboot.org/c/flashrom/+/86921?usp=email )
Change subject: libflashrom: Added API to enumerate supported programmers ......................................................................
Patch Set 2:
(2 comments)
File include/libflashrom.h:
https://review.coreboot.org/c/flashrom/+/86921/comment/fe0f46fe_73394f25?usp... : PS1, Line 166: * @return List of supported programmers, or NULL if an error occurred. Just to be explicit, this should say that the last entry in the returned list is followed by a NULL.
https://review.coreboot.org/c/flashrom/+/86921/comment/32d9d2b6_e0ffb585?usp... : PS1, Line 169: const char ** flashrom_supported_programmers(void);
I thought about this but flashrom already uses such approach in all […]
That the existing enumeration APIs return copies (I didn't realize that!) seems like a good enough reason to do the same for this one, even if we'd design it differently now. It can stay as you wrote it.
-
Peter Marheine (Code Review)