Attention is currently required from: Felix Singer, Thomas Heijligen, Angel Pons.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/68162 )
Change subject: meson: Move programmer test sources into programmer definition ......................................................................
Patch Set 10:
(1 comment)
File tests/meson.build:
https://review.coreboot.org/c/flashrom/+/68162/comment/43ca4663_fd76daa5 PS10, Line 32: p_data += { : 'testsrc' : p_data.get('testsrc', []), : } : srcs += p_data.get('testsrc') The idea is great, thank you!
I am confused by that it seems there are two different `testsrc` pieces of data and they mean different things? The first one comes from root meson.build, but then it is transformed into new testsrc which can be [] empty array? In other words, looks like `p_data.get('testsrc')` means different things in line 33 vs line 35?