[M] Change in flashrom[master]: flashrom: rewrite flashbuses_to_text() - flashrom-gerrit

2 Mar 2023


      Attention is currently required from: Felix Singer, Edward O'Callaghan, Angel Pons, Alexander Goncharov.
Anastasia Klimchuk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/73039 )
Change subject: flashrom: rewrite flashbuses_to_text()
......................................................................
Patch Set 5:
(1 comment)
File flashrom.c:
https://review.coreboot.org/c/flashrom/+/73039/comment/cb7a8dbe_733da77a 
PS4, Line 924: char *ret, *ptr;
...
Hmm... `strcat_realloc()` may return NULL. In such case `ret = strcat_realloc(ret, ... […]
Done
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/73039
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I59b9044c99b4ba6c00d8c97f1e91af09d70dce2c
Gerrit-Change-Number: 73039
Gerrit-PatchSet: 5
Gerrit-Owner: Alexander Goncharov chat@joursoir.net
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Felix Singer felixsinger@posteo.net
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Felix Singer felixsinger@posteo.net
Gerrit-Attention: Edward O'Callaghan quasisec@chromium.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Attention: Alexander Goncharov chat@joursoir.net
Gerrit-Comment-Date: Thu, 02 Mar 2023 11:39:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org
Comment-In-Reply-To: Alexander Goncharov chat@joursoir.net
Gerrit-MessageType: comment