Attention is currently required from: Felix Singer, Patrick Georgi, Evan Benn.
Evan Benn has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/69770 )
Change subject: test_build.sh: Add build_rust ......................................................................
Patch Set 1:
(2 comments)
File test_build.sh:
https://review.coreboot.org/c/flashrom/+/69770/comment/4d595893_4eaee444 PS1, Line 71: PKG_CONFIG_PATH="${install_dir}/lib/x86_64-linux-gnu/pkgconfig" not sure if we can derive this path or if this is good enough
https://review.coreboot.org/c/flashrom/+/69770/comment/c26c29b3_1ae4394e PS1, Line 87: do_for_rust test --offline this is not great as a user that has cargo but hasnt run this before needs to manually run the same commands without --offline. Not sure how I can do better, maybe the cargo commands will work without --offline on jenkins anyway?
-
Evan Benn (Code Review)