Change in flashrom[master]: tests/chips.c: Mock out open() for lock file
Attention is currently required from: Edward O'Callaghan, Anastasia Klimchuk. Daniel Campello has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62324 ) Change subject: tests/chips.c: Mock out open() for lock file ...................................................................... Patch Set 6: (5 comments) Commit Message: https://review.coreboot.org/c/flashrom/+/62324/comment/f30a75d4_fa63767f PS3, Line 7: out
You can remove "out". Just "Mock open() for all chip tests". […] Ack
Patchset: PS6: Squashed into CB:62320 File tests/chip.c: https://review.coreboot.org/c/flashrom/+/62324/comment/6a1f7efd_9fc4626b PS3, Line 212: data
Similarly as in previous patch, this can be `erase_chip_io_state` and same for the rest of the patch […] Ack
https://review.coreboot.org/c/flashrom/+/62324/comment/9fc819ad_41fa69da PS3, Line 213: "/run/lock/flashrom_lock"
If this is exactly identical path for all the chip tests, can be a macro in this file? Done
https://review.coreboot.org/c/flashrom/+/62324/comment/eef71adf_706f71f8 PS3, Line 222: io_mock_register(&chip_io);
You need to do `io_mock_register(NULL);` at the end of test, like verify tests do. Done
-- To view, visit https://review.coreboot.org/c/flashrom/+/62324 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: flashrom Gerrit-Branch: master Gerrit-Change-Id: I527a266233648b0eef11a89108e82d0a008eeb8d Gerrit-Change-Number: 62324 Gerrit-PatchSet: 6 Gerrit-Owner: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Reviewer: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Reviewer: Daniel Campello <campello@chromium.org> Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org> Gerrit-CC: Paul Menzel <paulepanter@mailbox.org> Gerrit-Attention: Edward O'Callaghan <quasisec@chromium.org> Gerrit-Attention: Anastasia Klimchuk <aklm@chromium.org> Gerrit-Comment-Date: Thu, 31 Mar 2022 04:29:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: Anastasia Klimchuk <aklm@chromium.org> Gerrit-MessageType: comment
participants (1)
-
Daniel Campello (Code Review)