Attention is currently required from: Nikolai Artemiev. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/53946 )
Change subject: flashchips.c: add support for W25Q32JW..IM ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/53946/comment/e1487d94_e01061de PS1, Line 17583: ..IM
Ah, I see the datasheet now. […]
ni845x_spi.c and dediprog.c uses voltage afaik. We have a dediprog auto-detect feature I have been meaning to get someone to clean up so it can be upstreamed. It's a lot more clean now than it use to be so we could probably send it soon.
That said, I think the one-off programming with external programmers sometimes being marginal is a frequent thing that is actually harmless in practice. The components are tested to withstand this sort of thing for short periods of time. "Not great, not terrible".
One day soon we should work out a way to deal with the detection of these parts that share common vid,did pairs if possible?
-
Edward O'Callaghan (Code Review)