Attention is currently required from: Anastasia Klimchuk.
Matti Finder has posted comments on this change by Matti Finder. ( https://review.coreboot.org/c/flashrom/+/84840?usp=email )
Change subject: cli_classic: Add rpmc command support ......................................................................
Patch Set 4:
(1 comment)
File cli_classic.c:
https://review.coreboot.org/c/flashrom/+/84840/comment/8ba2cb37_837095b6?usp... : PS4, Line 1323: if (options.rpmc_read_data) : ret = rpmc_read_data(fill_flash);
I am thinking, and maybe this is more the question to Peter, what do you think, […]
I agree I think the stuff from rpmc.c should rather be in libflashrom. I'm gonna move my code over there, and make it more api friendly. And then seperate the commits.
-
Matti Finder (Code Review)