Change in flashrom[master]: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric - flashrom-gerrit

10 Jan 2021


      Attention is currently required from: Xiang Wang, Stefan Reinauer, Angel Pons.
Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/49262 )
Change subject: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric
......................................................................
Patch Set 3:
(1 comment)
Commit Message:
https://review.coreboot.org/c/flashrom/+/49262/comment/9bb8064c_55e64011 
PS3, Line 7: bitbang_spi.c: fix bitbang_spi_send_command to make the delay symmetric
haha, again while it's a obvious patch for the author please do put some detail in the commit msg body as it helps the wider community understand it and learn from it.
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/49262
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Icf8b65aed20244ccffc231da2c599c6ca1796104
Gerrit-Change-Number: 49262
Gerrit-PatchSet: 3
Gerrit-Owner: Xiang Wang merle@hardenedlinux.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan quasisec@chromium.org
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Shawn C citypw@hardenedlinux.org
Gerrit-Attention: Xiang Wang merle@hardenedlinux.org
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Angel Pons th3fanbus@gmail.com
Gerrit-Comment-Date: Sun, 10 Jan 2021 05:34:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment