Attention is currently required from: Nico Huber, Edward O'Callaghan, Anastasia Klimchuk, Sergii Dmytruk. Nikolai Artemiev has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/58479 )
Change subject: libflashrom,writeprotect: add functions for reading/writing WP configs ......................................................................
Patch Set 29:
(5 comments)
Patchset:
PS22:
That sounds good. I'm working on implementing it now.
Done.
I've also moved all libflashrom functions to libflashrom.c to make way for linux_mtd support.
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/58479/comment/3e0bb11b_3647a7f6 PS27, Line 133: };
That sounds good to me, it's good to address ABI stability problems early on. […]
I went with the second option for the range list. Resolving as the original comment is done and CB:58481 is a better place to discuss the range list functions.
File libflashrom.h:
https://review.coreboot.org/c/flashrom/+/58479/comment/1f1abd47_8c6370b8 PS22, Line 125: software
I've removed the comment now, mentioning software protection is confusing/inaccurate since software […]
Resolving.
File writeprotect.c:
https://review.coreboot.org/c/flashrom/+/58479/comment/a0df967a_3f696fbe PS22, Line 56: struct wp_chip_config *cfg
Undoing done
Done
https://review.coreboot.org/c/flashrom/+/58479/comment/e34d3c83_ffcfb806 PS22, Line 145: which of two configurations should be used if they both select the same : * protection range
This was kind of an adaptation of an earlier function that just compared ranges so they could be sor […]
Done