Attention is currently required from: Angel Pons, Anastasia Klimchuk, Peter Marheine. Edward O'Callaghan has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/59277 )
Change subject: pcidev: Move scandev_inclass logic from internal to pcidev ......................................................................
Patch Set 4:
(2 comments)
This change is ready for review.
Commit Message:
https://review.coreboot.org/c/flashrom/+/59277/comment/9d047ba4_59bc0e78 PS2, Line 7: interal
typo: inter*n*al
Done
File board_enable.c:
https://review.coreboot.org/c/flashrom/+/59277/comment/2f1b5698_cf62ec1c PS2, Line 1553: /* First, look for a known LPC bridge */ : dev = pcidev_find_vendorclass(0x8086, 0x0601); /* ISA bridge */ : if (!dev) { : msg_perr("\nERROR: No known Intel LPC bridge found.\n"); : return -1; : } : /* Is this device in our list? */ : for (i = 0; intel_ich_gpio_table[i].id; i++) : if (dev->device_id == intel_ich_gpio_table[i].id) : break; : : if (!intel_ich_gpio_table[i].id) { : msg_perr("\nERROR: No known Intel LPC bridge found.\n"); : return -1; : }
This part belongs to a separate commit, it has nothing to do with renaming and moving `pci_dev_find_ […]
https://review.coreboot.org/c/flashrom/+/62405