[XS] Change in flashrom[main]: flashchips: add GD25B256E and GD25R256E - flashrom-gerrit

24 Aug 2024


      Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Victor Lim has posted comments on this change by Victor Lim. ( https://review.coreboot.org/c/flashrom/+/83998?usp=email )
Change subject: flashchips: add GD25B256E and GD25R256E
......................................................................
Patch Set 1:
(3 comments)
Patchset:
PS1: 
completed
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/83998/comment/c7687e4a_b04eec05?usp... :
PS1, Line 7461: FEATURE_WRSR_EXT2
...
Agree, will remove it and upload again
Done
https://review.coreboot.org/c/flashrom/+/83998/comment/55bbc987_86d887a8?usp... :
PS1, Line 7493: SPI_PRETTYPRINT_STATUS_REGISTER_BP3_SRWD
...
agree, will change it and upload again.
Done
-- 
To view, visit https://review.coreboot.org/c/flashrom/+/83998?usp=email
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: Ie733e0c2e35fa4797f5198f2c8334469b65f402c
Gerrit-Change-Number: 83998
Gerrit-PatchSet: 1
Gerrit-Owner: Victor Lim vlim@gigadevice.com
Gerrit-Reviewer: Anastasia Klimchuk aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev nartemiev@google.com
Gerrit-Comment-Date: Sat, 24 Aug 2024 04:23:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Victor Lim vlim@gigadevice.com
Comment-In-Reply-To: Anastasia Klimchuk aklm@chromium.org