Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/26261 )
Change subject: Enable writes with active ME ......................................................................
Patch Set 2:
(5 comments)
https://review.coreboot.org/#/c/26261/2/ichspi.c File ichspi.c:
https://review.coreboot.org/#/c/26261/2/ichspi.c@1591 PS2, Line 1591: 0 NO_PROT, same for below.
https://review.coreboot.org/#/c/26261/2/ichspi.c@1607 PS2, Line 1607: ~rwperms Would this not result in something out of range for the enum?
https://review.coreboot.org/#/c/26261/2/ichspi.c@1635 PS2, Line 1635: 0 NO_PROT
https://review.coreboot.org/#/c/26261/2/ichspi.c@1854 PS2, Line 1854: Not all flash regions are freely accessible by flashrom. This is " : "most likely\ndue to an active ME. Please see " : "https://flashrom.org/ME for details.\n") maybe should be updated to suggest to use layouts now.
https://review.coreboot.org/#/c/26261/2/ichspi.c@1867 PS2, Line 1867: ich_spi_rw_restricted should it not update programmer_may_write ?