Attention is currently required from: Nico Huber, Miklós Márton, Edward O'Callaghan, Anastasia Klimchuk.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57003 )
Change subject: ni845x_spi: add missing const specifier to the spi_transmit function
......................................................................
Patch Set 1:
(1 comment)
Patchset:
PS1:
Many thanks for the quick review!
Well the internal API seems to be changed since the ni845x_spi introduction and I have not built flashrom on Windows since then. As we discussed before it might be useful to create a mock C file for the ni845x.h library header to being able to perfrom least compilation tests (without Windows, mingw, and installed NI drivers). I actually started to work on this yesterday.
Speaking of mocks, this gives me an idea: how about making something that not only serves to build-test the code, but also allows running cmocka tests on ni845x?
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57003
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I2c14361283b2da3725d9ba2cae0e1007e6be3d66
Gerrit-Change-Number: 57003
Gerrit-PatchSet: 1
Gerrit-Owner: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Miklós Márton
martonmiklosqdev@gmail.com
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Comment-Date: Wed, 18 Aug 2021 06:59:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Miklós Márton
martonmiklosqdev@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment