Attention is currently required from: Anastasia Klimchuk, Nikolai Artemiev, Stefan Reinauer.
Alexander Goncharov has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/78874?usp=email )
Change subject: spi25_statusreg: rename amic_a25l032 print to a generic name
......................................................................
Patch Set 1:
(1 comment)
File flashchips.c:
https://review.coreboot.org/c/flashrom/+/78874/comment/22ce3a6d_29d91e09 :
PS1, Line 1278: /* bit5: T/B, bit6: prot size */
Is this comment useful? if yes, you can rename the function/enum but keep the comment
Since we are using a function that contain a register name, I don't see any point in this comment
`SEC_TB` = Sector Protect Size (SEC), Top/Bottom (TB)
--
To view, visit
https://review.coreboot.org/c/flashrom/+/78874?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: main
Gerrit-Change-Id: I7169a2312698343e1065cdca91a3985e00cb3804
Gerrit-Change-Number: 78874
Gerrit-PatchSet: 1
Gerrit-Owner: Alexander Goncharov
chat@joursoir.net
Gerrit-Reviewer: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Attention: Anastasia Klimchuk
aklm@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Wed, 08 Nov 2023 17:34:12 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Anastasia Klimchuk
aklm@chromium.org
Gerrit-MessageType: comment