[M] Change in flashrom[master]: drivers: Move (un)map_flash_region from programmer to par_master
Attention is currently required from: Edward O'Callaghan, Jonathon Hall, Nikolai Artemiev, Peter Marheine.
Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/67695 )
Change subject: drivers: Move (un)map_flash_region from programmer to par_master ......................................................................
Patch Set 5:
(5 comments)
Patchset:
PS5: I found more issues. The internal wbsio spi_master, uses an hybrid of memory mapping and spi commands. The sb600 promontory faces similar problems.
Unfortunately I'm on vacation the next weeks, so I've limited resources to look into all the issues coming with this change. But at this point already a huge thank you for all this work.
File atapromise.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/2d146c62_d81ea3b1 PS2, Line 133: atapromise_map
Removed this, also updated the comment in fallback_map() since returning NULL is the desired behavio […]
Done
File atavia.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/729a6eaa_8d905911 PS2, Line 147: atavia_map
I kept this around for now since I can't test it and it doesn't hurt the overall structure. […]
Done
File serprog.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/a816598f_0a913cbd PS2, Line 582: .map_flash_region = serprog_map,
Ah I see it now, I replaced the mapper with max_rom_decode for all bus types.
Done
File serprog.c:
https://review.coreboot.org/c/flashrom/+/67695/comment/9178b9ea_64821af5 PS5, Line 919: 1024 we have a `KiB` macro
-
Thomas Heijligen (Code Review)