Change in flashrom[master]: hwaccess: replace macros by C code

[Martin Roth (Code Review)]

Attention is currently required from: Nico Huber, Thomas Heijligen, Edward O'Callaghan, Angel Pons, Anastasia Klimchuk, Nikolai Artemiev.
Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/62898 )

Change subject: hwaccess: replace macros by C code
......................................................................

Patch Set 6:

(1 comment)

File hwaccess.h:

https://review.coreboot.org/c/flashrom/+/62898/comment/a52e4282_d57d1419 
PS6, Line 34: inline
> Why to force inline? The GCC should do a proper job for optimizing and I would trust it to do the ri […]

Okay, I thought you wanted it to always be inline to match what the macro was doing.  If you don't care whether it's actually inlined, then I agree the attribute isn't needed.

GCC will decide what to put inline based on the optimization level.  Currently, the Makefile sets the optimization to -Os, which should probably put this inline even without the inline statement since it enables inline-small-functions.

If we're trusting the compiler to do the "right" thing here, why even mark it inline at all?