David Hendricks has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/57793 )
Change subject: ich_descriptors: Add explicit checks for all chipsets
......................................................................
Patch Set 5:
(1 comment)
File ich_descriptors.c:
https://review.coreboot.org/c/flashrom/+/57793/comment/d7bd35fd_b7d2447b
PS1, Line 968: if (content->ICCRIBA != 0x34)
: msg_pwarn("Unknown flash descriptor, assuming 300 series compatibility.\n");
Regardless, this is not worth splitting hairs so I've reverted back to using msg_pwarn() since you […]
The codepaths aren't really "normalized" in this case, but Angel helpfully explained the rationale for leaving this snippet alone. Thanks, Angel.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/57793
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: Ica49477492876810a6fa212768b1ab9e8c12001f
Gerrit-Change-Number: 57793
Gerrit-PatchSet: 5
Gerrit-Owner: David Hendricks
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: David Hendricks
david.hendricks@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Sat, 02 Oct 2021 02:27:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: David Hendricks
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment