Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/flashrom/+/57800 )
Change subject: Remove "STANDALONE" comments ......................................................................
Remove "STANDALONE" comments
These comments doesn't add any more value. Thus, remove them.
Change-Id: I74288afde108e764adc651039aae81857abffedf Signed-off-by: Felix Singer felix.singer@secunet.com --- M cli_classic.c M cli_output.c 2 files changed, 9 insertions(+), 9 deletions(-)
git pull ssh://review.coreboot.org:29418/flashrom refs/changes/00/57800/1
diff --git a/cli_classic.c b/cli_classic.c index d69b798..c82b0cc 100644 --- a/cli_classic.c +++ b/cli_classic.c @@ -124,7 +124,7 @@
if (fstat(fileno(file), &statbuf) < 0) return false; -#endif /* !STANDALONE */ +#endif return true; }
@@ -232,7 +232,7 @@ char *fmapfile = NULL; #ifndef STANDALONE char *logfile = NULL; -#endif /* !STANDALONE */ +#endif char *tempstr = NULL; char *pparam = NULL; struct layout_include_args *include_args = NULL; @@ -455,7 +455,7 @@ case 'o': #ifdef STANDALONE cli_classic_abort_usage("Log file not supported in standalone mode. Aborting.\n"); -#else /* STANDALONE */ +#else if (logfile) { fprintf(stderr, "Warning: -o/--output specified multiple times.\n"); free(logfile); @@ -465,7 +465,7 @@ if (logfile[0] == '\0') { cli_classic_abort_usage("No log filename specified.\n"); } -#endif /* STANDALONE */ +#endif break; case OPTION_WP_SET_REGION: set_wp_region = 1; @@ -493,7 +493,7 @@ cli_classic_abort_usage(NULL); if (logfile && open_logfile(logfile)) cli_classic_abort_usage(NULL); -#endif /* !STANDALONE */ +#endif
#if CONFIG_PRINT_WIKI == 1 if (list_supported_wiki) { @@ -510,7 +510,7 @@
#ifndef STANDALONE start_logging(); -#endif /* !STANDALONE */ +#endif
print_buildinfo(); msg_gdbg("Command line (%i args):", argc - 1); @@ -869,6 +869,6 @@ #ifndef STANDALONE free(logfile); ret |= close_logfile(); -#endif /* !STANDALONE */ +#endif return ret; } diff --git a/cli_output.c b/cli_output.c index e12446d..240d02a 100644 --- a/cli_output.c +++ b/cli_output.c @@ -64,7 +64,7 @@ print_version(); verbose_screen = oldverbose_screen; } -#endif /* !STANDALONE */ +#endif
/* Please note that level is the verbosity, not the importance of the message. */ int flashrom_print_cb(enum flashrom_log_level level, const char *fmt, va_list ap) @@ -91,7 +91,7 @@ if (level != FLASHROM_MSG_SPEW) fflush(logfile); } -#endif /* !STANDALONE */ +#endif va_end(logfile_args); return ret; }