Attention is currently required from: Edward O'Callaghan, Nikolai Artemiev.
Sergii Dmytruk has posted comments on this change. ( https://review.coreboot.org/c/flashrom/+/64540 )
Change subject: ichspi.c: Implement read_write_status for wp
......................................................................
Patch Set 3:
(2 comments)
File ichspi.c:
https://review.coreboot.org/c/flashrom/+/64540/comment/36789db4_05e0f16c
PS2, Line 1349: static int ich_hwseq_read_status(const struct flashctx *flash, enum flash_reg reg_, uint8_t *value)
I think both functions should fail if reg_ is not SR1.
https://review.coreboot.org/c/flashrom/+/64540/comment/b1d90ebf_a7d242f8
PS2, Line 1352: int len = 1;
I'd make len a constant in both functions. It's used 15 lines below and one has to trace the code to understand that it's never updated.
--
To view, visit
https://review.coreboot.org/c/flashrom/+/64540
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: flashrom
Gerrit-Branch: master
Gerrit-Change-Id: I7ecbe8491ecea3697922c91af26ca62276e86317
Gerrit-Change-Number: 64540
Gerrit-PatchSet: 3
Gerrit-Owner: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Reviewer: Nikolai Artemiev
nartemiev@google.com
Gerrit-Reviewer: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Edward O'Callaghan
quasisec@chromium.org
Gerrit-Attention: Nikolai Artemiev
nartemiev@google.com
Gerrit-Comment-Date: Mon, 23 May 2022 12:13:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment